if consul_client_address set (in consul.conf), in the upstart script do not set -client flag … #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do not set -client flag (from unconfigurable interface 'eth0')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(from unconfigurable interface 'eth0')
In particular this fixes consul (upstart) service script deployment on any hosts that has an
eth0interface, which is not the expected interface you want consul to listen on.It ensures that with following settings, the upstart script does not anymore set a buggy
-client=parameter. Instead consul gets the correct client_address (here "0.0.0.0" ) from consul.confps: this also fixes #136 (as suggested in #136 (comment) by @nickvanw )