From 898db42663579daac8681f7e99f7f60c65e71175 Mon Sep 17 00:00:00 2001 From: Dominik Shaim Ulrich Date: Tue, 16 Jan 2024 16:37:51 +0100 Subject: [PATCH 1/3] Update SmtpConfigurationType.php --- .../AdvancedParameters/Email/SmtpConfigurationType.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php b/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php index dc6ad22d7db58..7fc660cab064c 100644 --- a/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php +++ b/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php @@ -65,6 +65,9 @@ public function buildForm(FormBuilderInterface $builder, array $options) 'empty_data' => '', 'label' => $this->trans('SMTP password', 'Admin.Advparameters.Feature'), 'help' => $this->trans('Leave blank if not applicable.', 'Admin.Advparameters.Help'), + 'attr' => [ + 'autocomplete' => 'new-password', + ] ]) ->add('encryption', ChoiceType::class, [ 'choices' => [ From c88c6632a29ff9fd152bfa387ee2e544ee167408 Mon Sep 17 00:00:00 2001 From: Dominik Shaim Ulrich Date: Wed, 17 Jan 2024 17:20:35 +0100 Subject: [PATCH 2/3] Make PHPCSFixer happy --- .../AdvancedParameters/Email/SmtpConfigurationType.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php b/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php index 7fc660cab064c..a89843b5f2cd5 100644 --- a/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php +++ b/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php @@ -67,7 +67,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) 'help' => $this->trans('Leave blank if not applicable.', 'Admin.Advparameters.Help'), 'attr' => [ 'autocomplete' => 'new-password', - ] + ], ]) ->add('encryption', ChoiceType::class, [ 'choices' => [ From 3383aa25ee41830f5558057c4f376f6f6a3ba99c Mon Sep 17 00:00:00 2001 From: Dominik Shaim Ulrich Date: Wed, 17 Jan 2024 17:21:33 +0100 Subject: [PATCH 3/3] Add Comment --- .../Configure/AdvancedParameters/Email/SmtpConfigurationType.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php b/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php index a89843b5f2cd5..6584b03ca7f31 100644 --- a/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php +++ b/src/PrestaShopBundle/Form/Admin/Configure/AdvancedParameters/Email/SmtpConfigurationType.php @@ -65,6 +65,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) 'empty_data' => '', 'label' => $this->trans('SMTP password', 'Admin.Advparameters.Feature'), 'help' => $this->trans('Leave blank if not applicable.', 'Admin.Advparameters.Help'), + /* Some browsers (for example Google Chrome) are totally ignoring "off" value, so we use "new-password" - which is working well for this purpose */ 'attr' => [ 'autocomplete' => 'new-password', ],