Script py3 and no bias update #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this require python 3 and based on others, it is suggested to add this. Also there is no update to bias which some other implementation and course may want it. Just a note. Not sure I dare to do the update bias in case there is a mistake. At least not in this pull request.
|
Hey, thank you for the work you did on this but because the blog post doesn't update the bias, I don't want to update it here. It's better to keep the two consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this require python 3 and based on others, it is suggested to add
this.
Also there is no update to bias which some other implementation and
course may want it. Just a note. Not sure I dare to do the update
bias in case there is a mistake. At least not in this pull request.