Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support arm64 on Darwin (Apple M1) #24

Open
davidjeddy opened this issue Apr 6, 2022 · 5 comments
Open

ENH: Support arm64 on Darwin (Apple M1) #24

davidjeddy opened this issue Apr 6, 2022 · 5 comments

Comments

@davidjeddy
Copy link

davidjeddy commented Apr 6, 2022

~ % sh install.sh                       
sh: install.sh: No such file or directory
~ % # Download the script
curl -sSLo install.sh https://install.hclq.sh

# Inspect the script before executing, as is good practice
# for code from the internet, regardless of trust!
less install.sh
...
# Run it!
sh install.sh
Unsupported or undetected platform: 'arm64'
 ~ % 

Edited platform_check() in install.sh

platform_check() {
  # OS and ARCH variables also used to download binary in main function
  OS="$(uname | awk '{print tolower($0)}')"
  ARCH="$(uname -m)"
  case "$ARCH" in
    amd64) ARCH=amd64;;
    x86_64) ARCH=amd64;;
    i386) ARCH=386;;
    i686) ARCH=386;;
    arm) ARCH=arm;;
    arm64) ARCH=arm;;
    *) fail "Unsupported or undetected platform: '$ARCH'";;
  esac
}

Tried install process again:

sh install.sh
Installing /usr/local/bin/hclq
hclq is not available for OS 'darwin' on architecture 'arm'
@kamilgregorczyk
Copy link

mac arm support would be great

@jelel-fliss
Copy link

need MAC support too

@RTae
Copy link

RTae commented Apr 21, 2023

M1 support please

@mcolussi-bigw
Copy link

You can still use the darwin amd64 binary since it will execute under Rosetta compatibility layer

@msarmadi
Copy link

in theory, pls test and add new make build target for MacOS M1 (can update install.sh downloaded on your own)

dist/hclq-macos-arm64:
  export GOOS=darwin GOARCH=arm64; $(BUILD_CMD) -o "$@"
  cd "$(@D)" && shasum -a 256 "$@" >> hclq-shasums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants