Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not compile because of an error on disk/mraid1x_linux.c #1

Open
ZacBouh opened this issue Jan 14, 2023 · 5 comments
Open

does not compile because of an error on disk/mraid1x_linux.c #1

ZacBouh opened this issue Jan 14, 2023 · 5 comments

Comments

@ZacBouh
Copy link

ZacBouh commented Jan 14, 2023

When trying to compile on raspbian (Linux 5.17.0) I get the following error

disk/mraid1x_linux.c: 181:15 Werror=array-bounds

Im not a C expert but I compared disk/mraid1x_linux.c to the original codebase version and it seems there is a typo at 181:15

@mattschwantes
Copy link
Owner

mattschwantes commented Jan 14, 2023

Thanks for the feedback.

In the readme, it mentions that this was originally obtained from grub-2.04.tar.gz at https://git.savannah.gnu.org/cgit/grub.git

I redownloaded the file from there just now and it is bitwise identical to the one I originally uploaded here 2.5 years ago.

As for compiling the code, did you use the instructions in the readme?

I have only verified this working on x64 Ubuntu 14.04, but others have been forking and building this code in recent years. I'm not really actively involved in this anymore.

@mattschwantes
Copy link
Owner

P.S. I assume before you are referring to "grub-2.04\grub-core\disk\mdraid1x_linux.c", as there doesn't seem to be a file called mraid1x_linux.c here.

@mattschwantes
Copy link
Owner

mattschwantes commented Jan 14, 2023

Comparing Grub-2.04 vs. Grub-2.06, there is a & present at 181:15 in 2.04 that is not present in 2.06 (actually there are a several code changes in that line). Nevertheless this is a RAID disk related item, the Surface doesn't have that type of hardware, so we probably don't need to build mdraid1x. Can you try building again using the instructions in the readme but leaving out mdraid1x from the final command?

@ZacBouh
Copy link
Author

ZacBouh commented Jan 14, 2023

Hi thanks for taking the time to come back to this.
I am noob to compiling, ill try to find how to retry compiling leaving out mdraid1x. I'll let you know.

@ZacBouh
Copy link
Author

ZacBouh commented Jan 14, 2023

If you have a suggestion on how I can compile leaving this module out I'd be grateful 😅
Still looking for how I can procede

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants