Merge pull request #37 from matushorvath/comments

Update comments
matushorvath · Apr 14, 2024 · 56579a3 · 56579a3
2 parents 3846143 + 304458e
commit 56579a3
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/util.s b/src/util.s
@@ -119,13 +119,16 @@ split_16_8_8:
 .ENDFRAME
 
 ##########
+# TODO use multiple entry points pattern, see vm8086 for implementation
+# TODO possibly use a table for split_8_4_4, see vm8086 for implementation
 split_hi_lo:
 .FRAME vin, bits; vh, vl, bit, pow, tmp             # returns vh, vl
     arb -5
 
     add 0, 0, [rb + vh]
     add [rb + vin], 0, [rb + vl]
 
+    # TODO Should this be add [rb + bits], 0, [rb + bit]? It would be faster for split_8_4_4.
     add 8, 0, [rb + bit]
 
 split_hi_lo_loop: