-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qualify uses of Not #83
Comments
Yes, the Once that is fixed, you could just be specific with what you use: using SimpleTraits: Trait, istrait, @traitdef, @traitimpl, @traitfn That is probably all that you need, without the |
Fixes #83 Also did some renames to use `$curmod` instead of `SimpleTraits` everywhere.
If you have time you could try out PR #84. |
Thanks for taking this up so quickly.
|
Thanks. Yes this works.
to prevent errors in inlined code from SimpleTraits source where SimpleTraits module is used to qualify names. |
No, better do:
as |
When importing both SimpleTraits and DataFrames, I do not figure out how to deal with
"both DataFrames and SimpleTraits export "Not"; uses of it in module TwPrototypes must be qualified"
Specifically, SimpleTraits somehow inlines unqualified usages of
Not
somewhere in the code, which I do not know how to transform to qualified, which causes compiler errors "UndefVarError: Not not defined" -> with stack traces leading into SimpleTraits source code.e.g.
@ ~/scratch/twutz/julia_cluster_depots/packages/SimpleTraits/l1ZsK/src/SimpleTraits.jl:171 [inlined]
I suggest as a first measure to replace "Not" by "SimpleTraits.Not" in all the code of SimpleTraits.
Is it possible to not export
Not
from SimpleTraits? Would this break too much depending code - which would need to adapt and qualify their usages ofNot
?Personally, I did not use
Not
explicitly yet (but obviously implicitly via macro) in my code.The text was updated successfully, but these errors were encountered: