Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter improvements #286

Open
juanca opened this issue Mar 31, 2021 · 2 comments
Open

Linter improvements #286

juanca opened this issue Mar 31, 2021 · 2 comments

Comments

@juanca
Copy link
Contributor

juanca commented Mar 31, 2021

  • transparent should be a valid color. Useful to avoid having to declare a background-color on a child element when its parent already has the correct color.
@juanca
Copy link
Contributor Author

juanca commented Mar 31, 2021

  • line-height should not be linted? Or we should allow setting line-heights to 100% since it is useful to vertically align text?
  • Using pixel values for line-height is useful to expand its container avoid cutting off the bottom parts of "g" and "y" (danglies).

@juanca
Copy link
Contributor Author

juanca commented Jun 11, 2021

A new property to track: grid-column-gap, gap, etc

We want to make gaps consistently sized in our application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant