Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous typography variables #30

Open
juanca opened this issue Jul 15, 2019 · 1 comment
Open

Miscellaneous typography variables #30

juanca opened this issue Jul 15, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@juanca
Copy link
Contributor

juanca commented Jul 15, 2019

We might want to consider evaluating the purposes of our defined variables. We might have jumped the gun and ported too many.

For example:

  --mavenlink-type-button-font-size: 14px;
  --mavenlink-type-body-font-size: 12px;
  --mavenlink-type-text-rendering: optimizeLegibility;

The button variable is better represented in the buttons style sheet.
The body font size and text rendering values seems too ambiguous in terms of our design system. Perhaps this is an indicator that we need to come up with a guide on structuring a new page to look like Mavenlink.

@juanca juanca added the bug Something isn't working label Jul 15, 2019
@roblevintennis
Copy link
Contributor

Yes, these are very old values. I think Huth may have experimented with an app-wide increase in font size and it just broke too many things? In any event, I've heard from design folks that we definitely want to go larger, and 12px is obviously quite small. Perhaps we will need to purposely diverge for an interim period in this case (haha, opposite side of argument from yesterday! 😋) Let's plan to discuss what this all means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants