Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing AcquireGimbalControlPopup #12328

Open
gillamkid opened this issue Jan 15, 2025 · 1 comment · May be fixed by #12339
Open

Missing AcquireGimbalControlPopup #12328

gillamkid opened this issue Jan 15, 2025 · 1 comment · May be fixed by #12339
Labels
Report: Bug

Comments

@gillamkid
Copy link
Contributor

gillamkid commented Jan 15, 2025 •
edited
Loading

In this PR (#11264), there was some logic added where certain gimbal actions will check if the Gimbal is acquired by someone else before commanding the gimbal action. If the gimbal is currently acquired by someone else, a showAcquireGimbalControlPopup signal gets emited. A comment says this is expected to be handled by QML. The problem is there is no such QML handling the signal

@Davidsastresas looks like you added that code. I assume you have a fork with the QML handler in it. Can you bring that to upstream?
@Davidsastresas
Copy link
Member

Hi Guillamkid. I took a quick look, and indeed that handler is missing, or maybe never implemented in the first place. Back when I did this with Julian it went through a lot of iterations, and maybe we missed that one. Feel free to make a PR, I will be happy to take a look.

Best regards!

@gillamkid gillamkid linked a pull request Jan 19, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Report: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "Request Gimbal Control" popup gillamkid/qgroundcontrol
2 participants
@Davidsastresas @gillamkid