Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to ring for consistency with axum-login #9

Closed
maxcountryman opened this issue Aug 29, 2022 · 0 comments
Closed

Consider switching to ring for consistency with axum-login #9

maxcountryman opened this issue Aug 29, 2022 · 0 comments

Comments

@maxcountryman
Copy link
Owner

I recently went through the exercise of putting together a crate for session-based user authentication and in doing that decided to use ring for HMAC. (I did this without thinking too much about it, since I've previously used ring in other projects.)

However, axum-extra (used for axum-sessions) uses the cookie crate which in turn uses the hmac crate. Previously, it looks like cookie used ring but it's unclear why the decision was made to move away from ring.

I should point out that this is not my area of expertise. I've chosen ring previously based on the apparent consensus that it's one of the premiere cryptographic crates with the primary difference between ring and the RustCrypto family being that parts of ring are not implemented in Rust (e.g. ring derives from BoringSSL).

Repository owner locked and limited conversation to collaborators Dec 9, 2022
@maxcountryman maxcountryman converted this issue into discussion #21 Dec 9, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant