Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes automatically quoting value in find_node_labels search #131

Merged
merged 2 commits into from
Dec 27, 2013
Merged

fixes automatically quoting value in find_node_labels search #131

merged 2 commits into from
Dec 27, 2013

Conversation

barnjamin
Copy link

If the value is an integer type it was being automatically quoted. I removed the quotes in the add_path argument and added a conditional to the build_path function to quote if the value is a string.

@maxdemarzi
Copy link
Owner

This change threw a whole bunch of errors... can you double check?

@barnjamin barnjamin closed this Dec 20, 2013
@barnjamin barnjamin reopened this Dec 20, 2013
@barnjamin
Copy link
Author

Not satisfied with how this looks but tests are passing and I added another one for properties with integers. Forgive my newness to ruby please :).

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 34a576d on barnjamin:master into 3b6f990 on maxdemarzi:master.

@maxdemarzi
Copy link
Owner

Thanks!

maxdemarzi added a commit that referenced this pull request Dec 27, 2013
fixes automatically quoting value in find_node_labels search
@maxdemarzi maxdemarzi merged commit 6f39b74 into maxdemarzi:master Dec 27, 2013
willkessler pushed a commit to willkessler/neography that referenced this pull request Apr 21, 2014
added delete callback for destroy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants