Added config settings for plugin paths #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it... I'll integrate it into the next release... waiting on dijkstra addition from Pablo Fernandez and I'll publish it. |
maxdemarzi
added a commit
that referenced
this pull request
Mar 22, 2012
Added config settings for plugin paths
willkessler
pushed a commit
to willkessler/neography
that referenced
this pull request
Apr 21, 2014
adding support for loading single relationships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Installed Neo4j on my mac using Homebrew, which means that my Cypher plugin is in a different location from the one expected by Neography. To get round this I added two extra attributes to the Neography::Config class - cypher_path and gremlin_path, which I set the values you were using in Neography::Rest. I updated Neography::Rest to use these config values.
I haven't written any tests because I'm not sure what tests I could write - any suggestions are welcome. My first thought was if the rest_plugin_specs still pass then that should be OK, but if you want me to add something extra let me know.
Cheers,
Nick