Added 2 more batch operations #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the neography/rest.rb 'get_batch' to add a case for :remove_node_from_index :delete_node Both method use the HTTP DELETE Methods and contain no 'body' Did not account for alias :remove_node_index Still need to add tests.
Added to spec tests to very that the operations... For testing batch delete node : - 2 node created one by one - Nodes deleted in batch - Get nodes results should be nil For testing batch remove node : - Create two nodes with indicies one by one - In batch remove the node from the indidicies - Search for exact nodes should be nil
|
Awesome! Thanks Samir. |
maxdemarzi
added a commit
that referenced
this pull request
Jun 20, 2012
Added 2 more batch operations
willkessler
pushed a commit
to willkessler/neography
that referenced
this pull request
Apr 21, 2014
Remove neo 2 specific spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Max, great job with neography.
In my use of neography, I found that I needed to support batch for a few operations not currently implemented in batch, so I took the liberty and
** Implemented
delete_nodeandremove_node_from_indexoperations. **This pull request adds the operations to the get_batch method in the 'lib/neography/rest.rb' file. I also added two spec fixtures to ensure that they work.
Let me know if you have see and issues that need fixing before accepting the request.
Thanks