Possible issue with Batch query interface (this time with a failing test) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added additional code to connection.rb - this code fixes the issue with the batch query, but it introduces a failure on another example. I believe that the failure is correct, and exposes another issue. |
maxdemarzi
added a commit
that referenced
this pull request
Apr 19, 2013
Possible issue with Batch query interface (this time with a failing test)
willkessler
pushed a commit
to willkessler/neography
that referenced
this pull request
Apr 21, 2014
Updating Gemfiles per 2.0.0-p353 requirements and final build of AMI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last pull request wasn't failing the test correctly. I guess I got mixed up before committing. Now this example fails properly to demonstrate the issue.
I'm not sure if this is an issue or not. Ultimately, it seems that one bad statement in a batch query fails the whole batch - without an error.