Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for adjustable image background #15

Open
Kofola45cz opened this issue Jul 24, 2022 · 6 comments
Open

Suggestion for adjustable image background #15

Kofola45cz opened this issue Jul 24, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Kofola45cz
Copy link
Contributor

Kofola45cz commented Jul 24, 2022

  • I'll say right off the bat that I know that for Images that have a partially transparent part, this feature wouldn't work because it would have to figure out pixel by pixel where the texture is or isn't, which is unnecessary....
  • I'm thinking more like if there was a checkbox in the interface, at hand, in the SignPicture GUI that would toggle that and then the player would have a choice of 16x basic Minecraft colors to put that color on the background image.
  • markings and colors would be enough for those already in Minecraft, for example for color writing in the book, etc.
  • it seems to me better than if the player has to put another picture, just for the background, and try to make as small a gap as possible
  • Thus, one side of the image and the other just the color, so the player when bypassing the image, would not see the mirrored image.
  • even though too many images would just put more strain on Minecraft
@maximuslotro maximuslotro self-assigned this Aug 2, 2022
@maximuslotro maximuslotro added the enhancement New feature or request label Aug 2, 2022
@maximuslotro
Copy link
Owner

Do you mean adding a solid color to the back of an image instead of seeing a reverse image?

@Kofola45cz
Copy link
Contributor Author

Kofola45cz commented Aug 2, 2022

Do you mean adding a solid color to the back of an image instead of seeing a reverse image?

Yep
-> of course on/off this option, otherwise there's no point in adding it

@maximuslotro
Copy link
Owner

Well how the images are rendered, its essentially a 2d image with no thickness, to add a solid back to it, it would require rendering a second image (solid colored) directly behind it.

@maximuslotro
Copy link
Owner

Essentially you would be loading two images for every image. Also i don't know where data for what color the image will be, should be stored. size and url is stored on the sign but it can only hold so much info.

@Kofola45cz
Copy link
Contributor Author

Kofola45cz commented Aug 2, 2022

Well, theoretically 1x character after or before the whole string would be enough (so as not to corrupt the data), and it would be enough to distinguish the color like in Minecraft Vanilla (&4 = dark red, &c = red -> https://www.digminecraft.com/lists/color_list_pc.php), and once it's there, when ON (when adding a background), signpicture would automatically recognize that there is a background and with what color?
Obviously it wouldn't be a url to the internet, but just to the basic Minecraft Vanilla colors palette saved in the mod, probably easily 1x1 pixel -> after all it would be purely one-color -> stretching, sizing, etc. would be according to the front image
Of course, care should be taken that the render of the back "image" or background is not a hard render after all it would have only one task, and that is to hide the view of the flipping image
Of course I understand that it is not easy, just because there is not already enough space for a sign and to avoid unnecessary bugs 😅

@maximuslotro
Copy link
Owner

maximuslotro commented Aug 2, 2022

Well if I've learned anything my time from coding: The bugs will come crawling!😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants