object_arg_parser: replacing file paths by URLs

in the hope to improve windows support,
possibly addressing #186

Author: maxlath

lib/object_arg_parser.js

@@ -1,6 +1,7 @@
+import { existsSync } from 'node:fs'
 import { red } from '#lib/chalk'
 import { readJsonFile } from '#lib/json'
-import { isFilePathSync, isJsonString, getAbsoluteFilePath, validateTemplateCommand } from '#lib/utils'
+import { isJsonString, getAbsoluteFileUrl, validateTemplateCommand } from '#lib/utils'
 import { parseGuid } from './parse_command_utils.js'
 import program from './program.js'
 import validateFunctionArgs from './validate_function_args.js'
@@ -20,22 +21,22 @@ const getData = args => {
     return JSON.parse(arg)
   }
 
-  const filepath = getAbsoluteFilePath(arg)
+  const fileUrl = getAbsoluteFileUrl(arg)
 
-  if (!isFilePathSync(filepath)) {
+  if (!existsSync(fileUrl)) {
     console.error(red('the argument should be a valid JSON or a JSON file path or a JS function file path'))
     console.error("- it doesn't look like inline JSON")
-    console.error(`couldn't parse arguments: ${filepath} is not the path to an existing file`)
+    console.error(`couldn't parse arguments: ${fileUrl} is not the path to an existing file`)
     process.exit(1)
   }
 
   try {
     // Try to parse it as a JSON file
-    return readJsonFile(filepath)
+    return readJsonFile(fileUrl)
   } catch (err1) {
     // Try to parse it as a JS module
     try {
-      return getDataFromJsModule(filepath, args)
+      return getDataFromJsModule(fileUrl, args)
     } catch (err2) {
       if (err2 === 'SyntaxError') {
         console.error(red('the argument should be a valid JSON or a JSON file path or a JS function file path'))
@@ -50,8 +51,8 @@ const getData = args => {
   }
 }
 
-async function getDataFromJsModule (filepath, args) {
-  const { default: jsModule } = await import(filepath)
+async function getDataFromJsModule (fileUrl, args) {
+  const { default: jsModule } = await import(fileUrl)
   if (typeof jsModule === 'function') {
     const inputArgs = args.slice(1)
     validateFunctionArgs(jsModule, inputArgs, jsModule)

lib/utils.js

@@ -1,29 +1,30 @@
 import { existsSync } from 'node:fs'
 import path from 'node:path'
+import { pathToFileURL } from 'node:url'
 import errors_ from './errors.js'
 
 export const wait = ms => new Promise(resolve => setTimeout(resolve, ms))
 
 export const sum = (a, b) => a + b
 
-export const average = values => {
+export function average (values) {
   if (values.length > 0) return values.reduce(sum, 0) / values.length
   else return 0
 }
 
-export const getAbsoluteFilePath = filepath => path.resolve(process.cwd(), filepath)
+export const getAbsoluteFileUrl = filepath => pathToFileURL(path.resolve(process.cwd(), filepath))
 
-export const isFilePathSync = arg => {
-  const possibleFilePath = getAbsoluteFilePath(arg)
-  return existsSync(possibleFilePath)
+export function isFilePathSync (arg) {
+  const possibleFileUrl = getAbsoluteFileUrl(arg)
+  return existsSync(possibleFileUrl)
 }
 
-export const isJsonString = str => {
+export function isJsonString (str) {
   if (typeof str !== 'string') return false
   else return (str.trim()[0] === '{' || str.trim()[0] === '[')
 }
 
-export const validateTemplateCommand = ({ commandName, validCommands }) => {
+export function validateTemplateCommand ({ commandName, validCommands }) {
   if (!validCommands) return
   if (validCommands && !validCommands.includes(commandName)) {
     throw errors_.exitMessage('wrong command for this template', { commandName, validCommands })