Ensure Consistent Category Colors #1722
Open
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JLambertazzo just an idea here—what if we used a simple Stimulus controller to hide the color picker entirely if the parent category field is populated, then on the backend, we simply use our internal logic to assign the parent color to the subcategory? cc @justinfar in case you had other ideas here. |
This worked really well! Here are the results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1668
Note
Was not able to accomplish reactivity in this PR. Disabling of other colors, in addition to displaying the error message, only shows up after a failed attempt to create the category.
Approach
category.rbmodel which displays the message below when trying to select a color different from the parent category