From f36dc736620484049c68d3010c12527934bb280c Mon Sep 17 00:00:00 2001 From: Julian Roeland Date: Fri, 13 Dec 2024 11:05:12 +0100 Subject: [PATCH 1/2] :art: - refactor: accessability improvement --- src/components/data/attributetable/attributetable.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/data/attributetable/attributetable.tsx b/src/components/data/attributetable/attributetable.tsx index 6920e58b..68507aa0 100644 --- a/src/components/data/attributetable/attributetable.tsx +++ b/src/components/data/attributetable/attributetable.tsx @@ -103,6 +103,7 @@ export const AttributeTable = ({ return (
({ className={clsx("mykn-attributetable__row", { "mykn-attributetable--compact": compact, })} + role="row" >
({ "mykn-attributetable__cell--key", { "mykn-attributetable--compact": compact }, )} + role="cell" > {isEditing ? : label}
From ae5cbe8bce409a5ac2b76fa278394582ae65f6fc Mon Sep 17 00:00:00 2001 From: Julian Roeland Date: Fri, 13 Dec 2024 17:38:27 +0100 Subject: [PATCH 2/2] :bug: - fix: attempt to fix ci --- package-lock.json | 34 +++++++++++++++++++++++++--------- package.json | 1 + 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/package-lock.json b/package-lock.json index 497f0cfd..144a8086 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,6 +20,7 @@ "@commitlint/config-conventional": "^19.0.0", "@formatjs/cli": "^6.2.7", "@formatjs/ts-transformer": "^3.13.12", + "@playwright/test": "^1.48.0", "@rollup/plugin-commonjs": "^25.0.7", "@rollup/plugin-json": "^6.1.0", "@rollup/plugin-terser": "^0.4.4", @@ -2790,6 +2791,21 @@ "url": "https://opencollective.com/unts" } }, + "node_modules/@playwright/test": { + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.49.1.tgz", + "integrity": "sha512-Ky+BVzPz8pL6PQxHqNRW1k3mIyv933LML7HktS8uik0bUXNCdPhoS/kLihiO1tMf/egaJb4IutXd7UywvXEW+g==", + "dev": true, + "dependencies": { + "playwright": "1.49.1" + }, + "bin": { + "playwright": "cli.js" + }, + "engines": { + "node": ">=18" + } + }, "node_modules/@rollup/plugin-commonjs": { "version": "25.0.7", "resolved": "https://registry.npmjs.org/@rollup/plugin-commonjs/-/plugin-commonjs-25.0.7.tgz", @@ -13694,33 +13710,33 @@ } }, "node_modules/playwright": { - "version": "1.41.0", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.41.0.tgz", - "integrity": "sha512-XOsfl5ZtAik/T9oek4V0jAypNlaCNzuKOwVhqhgYT3os6kH34PzbRb74F0VWcLYa5WFdnmxl7qyAHBXvPv7lqQ==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.49.1.tgz", + "integrity": "sha512-VYL8zLoNTBxVOrJBbDuRgDWa3i+mfQgDTrL8Ah9QXZ7ax4Dsj0MSq5bYgytRnDVVe+njoKnfsYkH3HzqVj5UZA==", "dev": true, "dependencies": { - "playwright-core": "1.41.0" + "playwright-core": "1.49.1" }, "bin": { "playwright": "cli.js" }, "engines": { - "node": ">=16" + "node": ">=18" }, "optionalDependencies": { "fsevents": "2.3.2" } }, "node_modules/playwright-core": { - "version": "1.41.0", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.41.0.tgz", - "integrity": "sha512-UGKASUhXmvqm2Lxa1fNr8sFwAtqjpgBRr9jQ7XBI8Rn5uFiEowGUGwrruUQsVPIom4bk7Lt+oLGpXobnXzrBIw==", + "version": "1.49.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.49.1.tgz", + "integrity": "sha512-BzmpVcs4kE2CH15rWfzpjzVGhWERJfmnXmniSyKeRZUs9Ws65m+RGIi7mjJK/euCegfn3i7jvqWeWyHe9y3Vgg==", "dev": true, "bin": { "playwright-core": "cli.js" }, "engines": { - "node": ">=16" + "node": ">=18" } }, "node_modules/playwright/node_modules/fsevents": { diff --git a/package.json b/package.json index 7cac7b11..d258102a 100644 --- a/package.json +++ b/package.json @@ -60,6 +60,7 @@ }, "homepage": "https://github.com/maykinmedia/admin-ui/#readme", "devDependencies": { + "@playwright/test": "^1.49.1", "@chromatic-com/storybook": "^2.0.2", "@commitlint/cli": "^19.0.0", "@commitlint/config-conventional": "^19.0.0",