From 63c1c7a22fe517f83d109cf54d7cc071a64c05ac Mon Sep 17 00:00:00 2001 From: Steven Bal Date: Tue, 2 Jul 2024 12:41:27 +0200 Subject: [PATCH 1/2] :arrow_up: Upgrade mozilla-django-oidc-db to >=0.19.0 --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index a54e4f3..9bafbc2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -46,7 +46,7 @@ Changelog = "https://github.com/maykinmedia/django-digid-eherkenning/blob/master [project.optional-dependencies] oidc = [ - "mozilla-django-oidc-db>=0.18.0", + "mozilla-django-oidc-db>=0.19.0", ] tests = [ "django-test-migrations", From 51c051bfa3e27709d4ab986ec236cfcc5049c154 Mon Sep 17 00:00:00 2001 From: Steven Bal Date: Tue, 2 Jul 2024 12:41:46 +0200 Subject: [PATCH 2/2] :fire: Remove oidc_exempt_urls from config models this field was never actually used, and it does not make sense to make settings that refer to Django stuff (URL patterns in this case) manually configurable instead of programmatically. It caused issues in Open Forms (#4435) where it required manual action from admins if it was kept as a model field. --- digid_eherkenning/oidc/admin.py | 1 - ...e_digidconfig_oidc_exempt_urls_and_more.py | 32 +++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 digid_eherkenning/oidc/migrations/0009_remove_digidconfig_oidc_exempt_urls_and_more.py diff --git a/digid_eherkenning/oidc/admin.py b/digid_eherkenning/oidc/admin.py index 22ca344..8e0bebe 100644 --- a/digid_eherkenning/oidc/admin.py +++ b/digid_eherkenning/oidc/admin.py @@ -54,7 +54,6 @@ "oidc_use_nonce", "oidc_nonce_size", "oidc_state_size", - "oidc_exempt_urls", "userinfo_claims_source", ), "classes": ["collapse in"], diff --git a/digid_eherkenning/oidc/migrations/0009_remove_digidconfig_oidc_exempt_urls_and_more.py b/digid_eherkenning/oidc/migrations/0009_remove_digidconfig_oidc_exempt_urls_and_more.py new file mode 100644 index 0000000..52bb964 --- /dev/null +++ b/digid_eherkenning/oidc/migrations/0009_remove_digidconfig_oidc_exempt_urls_and_more.py @@ -0,0 +1,32 @@ +# Generated by Django 4.2.11 on 2024-07-01 15:15 + +from django.db import migrations + + +class Migration(migrations.Migration): + + dependencies = [ + ( + "digid_eherkenning_oidc_generics", + "0008_digidconfig_loa_value_mapping_and_more", + ), + ] + + operations = [ + migrations.RemoveField( + model_name="digidconfig", + name="oidc_exempt_urls", + ), + migrations.RemoveField( + model_name="digidmachtigenconfig", + name="oidc_exempt_urls", + ), + migrations.RemoveField( + model_name="eherkenningbewindvoeringconfig", + name="oidc_exempt_urls", + ), + migrations.RemoveField( + model_name="eherkenningconfig", + name="oidc_exempt_urls", + ), + ]