Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging #49

Open
pi-sigma opened this issue Nov 23, 2023 · 0 comments
Open

Refactor logging #49

pi-sigma opened this issue Nov 23, 2023 · 0 comments

Comments

@pi-sigma
Copy link
Contributor

The current implementation of logging has a few problems:

  • The login_sucess message is contained in error_messages on the BaseBackend, which is confusing
  • The message strings are translated, even though they are only (?) used for logging, which means they end up translated in log aggregating systems
  • The logging calls are wrapped in a way that makes it impossible to pass arguments to the extra paremeter of the logger calls. This is important because we want to pass arguments to extra containing information about the context of the particular logger call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant