Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompanyName with KPN as eHerkenningsbroker returnes an EncryptedAttribute, which means that generated eHerkenning metadata doesn't work #82

Open
alextreme opened this issue Aug 26, 2024 · 2 comments

Comments

@alextreme
Copy link
Member

Discussed with @LaurensBurger , encountered with Het Hogeland OF

CompanyName is now included in the eHerkenning metadata (this seems to be included by @SilviaAmAm earlier this year via https://github.com/maykinmedia/django-digid-eherkenning/blame/master/digid_eherkenning/models/eherkenning.py

This works fine as long as the CompanyName is not encrypted, however an issue I still remember from the early days with Alexander is that KPN encrypts the CompanyName as they consider it sensitive data, while the other eHerkenning makelaars don't

This, combined with the fact that we don't support EncryptedAttributes (eg: "The Response could not be validated due to the following error: There is an EncryptedAttribute in the Response and this SP not support them") means that we are currently generating eHerkenning metadata which won't work when used with KPN. This can be modified manually however Laurens and I suggest to remove the CompanyName from the automatically-generated metadata as OF and OIP retrieve this via the KVK API instead.

@maykinmedia maykinmedia deleted a comment Aug 26, 2024
@maykinmedia maykinmedia deleted a comment Aug 26, 2024
@maykinmedia maykinmedia deleted a comment Aug 26, 2024
@sergei-maertens
Copy link
Member

combined with the fact that we don't support EncryptedAttributes

do you have any more information about this? Since I'm dangerously close to running into similar issues.

@alextreme
Copy link
Member Author

@sergei-maertens Sure, Alexander was way ahead of us 😛

https://taiga.maykinmedia.nl/project/alex-belastingdienst-vips/issue/2039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@alextreme @sergei-maertens and others