Fix metadata file creation #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_metadata method from saml library returns bytes but this was confusing in the docstrings as they mention str.So, what we get from this method is used directly to create the file (idp_metadata_file).
vaszig
force-pushed
the
fix/xml-metadata-file-creation
branch
from
53ece58 to
3976e40
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 71 71
Lines 3212 3212
=======================================
Hits 3084 3084
Misses 128 128 ☔ View full report in Codecov by Sentry. |
sergei-maertens
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#3873