-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command to show eHerkenning services. #57
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 96.01% 96.10% +0.08%
==========================================
Files 72 73 +1
Lines 3216 3260 +44
==========================================
+ Hits 3088 3133 +45
+ Misses 128 127 -1 ☔ View full report in Codecov by Sentry. |
service_provider = tree.xpath( | ||
f"esc:ServiceProvider[esc:ServiceProviderID/text()='{oin}']", | ||
namespaces=NAMESPACES, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The oin
argument is not required, what happens if it is None
?
|
||
|
||
class Command(BaseCommand): | ||
help = "Updates the stored metadata file and prepopulates the db fields." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this help text matches what the command does?
Running this command will download the service catalog and shows all services for given organisation number.
Example: