Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58] Do not swap entityID with URL for eH #62

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Mar 1, 2024

Fixes #58
Fixes open-formulieren/open-forms#3950 partially

Extra context for the original change:
#45
#46

@SilviaAmAm SilviaAmAm marked this pull request as draft March 1, 2024 15:45
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (970d3ed) to head (e79459f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          72       72           
  Lines        3216     3216           
=======================================
  Hits         3088     3088           
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review March 4, 2024 07:54
@SilviaAmAm SilviaAmAm requested a review from vaszig March 4, 2024 10:13
@vaszig vaszig merged commit a3eda6f into master Mar 5, 2024
14 checks passed
@vaszig vaszig deleted the fix/58-wrong-entity-id branch March 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants