Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks #56

Open
aalin opened this issue Feb 2, 2023 · 0 comments
Open

Benchmarks #56

aalin opened this issue Feb 2, 2023 · 0 comments

Comments

@aalin
Copy link
Contributor

aalin commented Feb 2, 2023

It would be useful to implement some sort of benchmarks that can run in GitHub Actions.

Without benchmarks, it's difficult to know whether a change has a positive or negative impact on performance.
The new diffing algorithm ran faster in my tests, but in the real world maybe it allocates more objects and therefore results in

It would be nice to have benchmarks for:

  • List insertion
  • List removal
  • List reorder
  • Deeply nested structures
  • Periodic updates

Could maybe use https://ruby-prof.github.io/ to get the numbers.
@aalin aalin mentioned this issue Feb 2, 2023
Open
aalin added a commit that referenced this issue Feb 7, 2023
@aalin
Re-enable perf.test.rb
9e0fd24 
Related to #56...
This test is probably not very good, but it's a start.
Would be good to have tests for different scenarios,
not exactly sure what though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aalin