-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link button styling #62
Comments
For the record: I removed Marx from the list for now. |
Hi @troxler, what makes you say the HTML is invalid? According to MDN,
[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button |
The content model of the |
Thanks! Today I learned. I'm not the maintainer but it should be pretty easy for you to open a pull request that removes the link button example. |
This should do the job: #64 |
Describe the bug
Link buttons in the demo are using invalid HTML. Nesting buttons within links is invalid and semantically incorrect.
To Reproduce
The demo is using
<a href="#"><button>Button Link</button></a>
for link buttons.Expected behavior
Valid HTML.
Additional context
I maintain a list of CSS frameworks where Marx is listed. Using valid HTML and proper semantics is a requirement to be listed.
The text was updated successfully, but these errors were encountered: