Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving tabs across windows copies them instead #1723

Closed
sig-kill opened this issue Jul 18, 2024 · 6 comments
Closed

Moving tabs across windows copies them instead #1723

sig-kill opened this issue Jul 18, 2024 · 6 comments

Comments

@sig-kill
Copy link

sig-kill commented Jul 18, 2024

Steps to reproduce

  • Open Firefox in a new profile
  • Install Sidebery
  • Open a new window (shown left)
    • image
  • Drag a tab from one Sidebery panel to the other

Actual behavior

Tab is copied over to the new window, and not active:
image

Expected behavior

Tab should be moved from the old window and made active in the new window. Result in the example should be this:
image

Moving tabs used to behave this way seamlessly (even moving a playing Youtube tab across windows worked without interrupting the video) so it seems like there's a regression.

System

Windows 10

Firefox version

129.0b5

Sidebery version

5.2.0

Logs

No console logs
@ForsakenHarmony
Copy link

Wonder if this is the same issue as #1714

@geduardcatalindev
Copy link

geduardcatalindev commented Aug 8, 2024

I have the exact same problem using the same versions of Firefox and Sidebery mentioned by @sig-kill

@Bobo1239
Copy link

Bobo1239 commented Aug 8, 2024

Did some debugging like in #1714 (comment) and the regression is caused by the same Firefox change. Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1912340 upstream since it's a different bug than what causes #1714 which already has a patch pending.

@Bobo1239
Copy link

Bobo1239 commented Aug 23, 2024

The just released Firefox Nightly contains the fix and afaict everything works again. 🎉 All credits go to David Parks (handyman) who wrote the patches. Currently it is slated to land in Firefox 131 (scheduled for Oct. 1) but they may deem this important/unrisky enough to uplift to an earlier release.

Update: Got uplifted to beta (starting 130.0rc1) and should land on stable on September 3.

@sig-kill
Copy link
Author

That's great news. Thanks for following up!

@sig-kill
Copy link
Author

sig-kill commented Sep 9, 2024

Confirmed working on 131.0b3

@sig-kill sig-kill closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants