Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if Msaa is disabled/enabled after adding the plugin #15

Open
mbrea-c opened this issue Apr 1, 2024 · 0 comments
Open

Crash if Msaa is disabled/enabled after adding the plugin #15

mbrea-c opened this issue Apr 1, 2024 · 0 comments

Comments

@mbrea-c
Copy link
Owner

mbrea-c commented Apr 1, 2024

Reproduction

Change the main function in the pbr example to:

    let mut app = App::new();
    app.add_plugins(DefaultPlugins);
    app.add_plugins(ParticleSystemPlugin)
        .add_systems(Startup, setup);
    app.insert_resource(Msaa::Off);
    app.run();

Expected

The example runs normally, but with Msaa disabled.

Actual result

The example crashes

Reasoning

Currently we setup the texture bindings that the plugin uses at plugin build time, but those bindings are dependent on whether Msaa is enabled or not. They need to be recreated whenever the Msaa resource changes.
This is the reason for the third crash in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant