Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Poor performance in merge sorted arrays #7

Open
mbrt opened this issue Oct 9, 2015 · 2 comments
Open

Poor performance in merge sorted arrays #7

mbrt opened this issue Oct 9, 2015 · 2 comments
Labels
enhancement refactor

Comments

@mbrt
Copy link
Owner

mbrt commented Oct 9, 2015

This occurs when merging a new signature into a chain, in signature module. Consider using a custom unsafe function or (if possible) itertools::merge_by.
@mbrt mbrt changed the title Performance issue in merge sorted arrays Poor performance in merge sorted arrays Oct 9, 2015
@mbrt
Copy link
Owner Author

mbrt commented Oct 16, 2015

For a reference implementation (in java) see In-place merge of two arrays (stackoverflow).

@mbrt
Copy link
Owner Author

mbrt commented Oct 16, 2015

Suggestion in #rust IRC: use chunks_mut and split_at_mut.

@mbrt mbrt added the refactor label Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbrt