-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated compat versions and Fast tweak for tests to all work #69
base: master
Are you sure you want to change the base?
Conversation
Any movement on this @mcabbott ? As it currently stands, I cannot use TensorCast with some more modern packages I need. |
Can you say which packages? I would prefer not to touch most of these bounds. But e.g. LazyArrays could probably allow 1.0? Haven't tested but would prefer to change exactly one thing at a time. For Strided.jl, perhaps this package should have no bounds, but Strided v2 needs code changes to TransmuteDims.jl and I haven't got around to figuring them out, sorry. (On that, mcabbott/TransmuteDims.jl#41 and Jutho/Strided.jl#25 are the issues.) |
It is exactly the Strided v2 code changes I am referring to. It is required by ITensors. |
Forgot about this, sorry. Just pushed 2c500cc to allow Strided@2, needs mcabbott/TransmuteDims.jl#43 Locally, LazyArrays@1 led to an error, let's see what CI thinks.
|
This still does not solve the issue for packages that depend on TensorCast and require new versions of other packages. Are there any plans to merge mcabbott/TransmuteDims.jl#43 soon? |
Updated versions and changed the
TensorCast
import in theFast
module so that the tests all work. I don't know if correct to do that.TransmuteDims
is set to the current version 0.1.15 without the Strided v2UnsafeStridedView
changes in the PR Update Strided dep to v2 #41.