Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed values for lang and hreflang attribute #798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arttiger
Copy link

@arttiger arttiger commented Sep 6, 2021

Regional langs xx_YY it's not a valid value for that attribute. It should be xx-YY

Regional langs xx_YY it's not a valid value for that attribute. It should be xx-YY
@rickwest
Copy link

rickwest commented Sep 10, 2021

The regional value is used internally for setting the regional locale (so formatLocalized works in Carbon) and is in the correct format for that.

@arttiger
Copy link
Author

In this case, in my opinion, the regional key should be renamed tolocalewhich will correspond to the Carbon documentation. And to each language add the hreflang key, which will be used for SEO for<link rel = "alternate" hreflang = "{{$ properties ['hreflang']}}" href = "#">and in what value the locale key will be specified in xx-YY format. If you now use the format xx_YY for hreflang service validator.w3.org reports that this is an incorrect format.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants