-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert public API to builder pattern #17
Comments
I was thinking the same thing around the Options struct. My current PR that adds default_tags to I was thinking something along these lines. If you are in agreement I can either include both changes in the single PR or open the builder after the other one is merged. |
I think opening that up as a separate PR would be great! |
Opened the PR. On an unrelated note is there a road-map or a planned time when you might release a new version of the crate with this and the previous PR that added the default tags? |
@dwdking I just merged the options builder PR and released a new version! (0.7.0) |
Trying to provide a clean API that has lots of optional fields is pretty verbose right now, as was made clear by service checks, not to mention all the options that events support that we should add. My thought is to transition the API to more of a builder pattern, so that you never have to specify the optional arguments that you don't care about:
or
The text was updated successfully, but these errors were encountered: