Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #23

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Various updates #23

wants to merge 14 commits into from

Conversation

mortendahl
Copy link

Various updates:

Regarding rated versions, I would be tempted to remove the non-rated but this means taking &mut self references everywhere; perhaps this isn't an issue. Having rated also means a dependency on rand.

@lolgesten
Copy link

@mcasper did you see this PR? it looks yummy!

@mcasper
Copy link
Owner

mcasper commented Feb 24, 2019

Hey @mortendahl, sorry for the really slow response. There's a lot of great stuff in here! It's a little challenging to review this large of a PR though, could you break the logical changes down into separate PRs for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full support for each metric type's options
3 participants