New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SNS FCM payload #32

Open

lightglitch opened this issue Aug 6, 2020 · 2 comments

lightglitch commented Aug 6, 2020

In your code you have different payloads keys for FCM and GCM

https://github.com/mcfedr/awspushbundle/blob/master/src/Mcfedr/AwsPushBundle/Message/Message.php#L700

But according to SNS documentation

https://docs.aws.amazon.com/sns/latest/dg/sns-send-custom-platform-specific-payloads-mobile-devices.html

you should always use GCM as key, where did you see the FCM information?

Owner

mcfedr commented Aug 16, 2022

Yea, it does seem to be right, maybe a PR that removes FCM is needed

MrDanshur commented Mar 30, 2023

@mcfedr, please, review the PR https://github.com/mcfedr/awspushbundle/pull/46/files
it should fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment