Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wheels are gzipped instead of zipped #434

Open
jesterKing opened this issue Nov 29, 2021 · 2 comments
Open

Python wheels are gzipped instead of zipped #434

jesterKing opened this issue Nov 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working build issues related to build tools, ci, etc. help wanted Extra attention is needed py

Comments

@jesterKing
Copy link
Member

For package upload to work properly with python -m twine upload dist/* the wheels should be zipped instead of gzipped. The gzip format causes the twine upload to fail with BadZipFile exception.

Additionally the wheel files until 7.7.0 on https://pypi.org/project/rhino3dm have the rhino3dm and rhino3dm-x.yy.z-dist-info folders at the top. The current release workflow has an extra level in there that doesn't help. It appears that this extra level is itself an archive. This level appears to be the wanted zip file.

image

image

@fraguada
Copy link
Member

fraguada commented Dec 1, 2021

These are gzipped with the artifacts action used by upload-artifact: https://github.com/actions/toolkit/blob/master/packages/artifact/docs/additional-information.md#is-my-artifact-compressed

@fraguada fraguada added bug Something isn't working build issues related to build tools, ci, etc. py labels Dec 1, 2021
@jesterKing
Copy link
Member Author

After extracting the all wheel zip on the Mac I used the following zsh script to rezip all the wheels

for i in *.whl; do                          
    fldr=`basename -s .whl $i`
    mkdir -p $fldr
    tar xvzf $i -C $fldr
    mv $i $i.bak
    zip -r $i $fldr/*
done

@fraguada fraguada added the help wanted Extra attention is needed label Aug 10, 2022
@fraguada fraguada self-assigned this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build issues related to build tools, ci, etc. help wanted Extra attention is needed py
Projects
None yet
Development

No branches or pull requests

2 participants