feat: add dev ui #1036

Dudeplayz · 2024-11-03T13:18:58Z

Implements #33

quarkus-hilla-bot · 2024-11-03T13:19:31Z

Format Checker Report

There are 4 files with format errors.

To fix the build, please run mvn spotless:apply in your branch and commit the changes.
Alternatively, apply the auto-format label to the PR.

Files with format issues in this PR

commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointBuildItem.java
commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/QuarkusHillaDevUICommonsProcessor.java
lit/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
react/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java

Full Diff

diff --git a/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointBuildItem.java b/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointBuildItem.java
index f73f2d1..32b0ace 100644
--- a/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointBuildItem.java
+++ b/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointBuildItem.java
@@ -32,8 +32,6 @@ public final class EndpointBuildItem extends SimpleBuildItem {
     }
 
     public int getEndpointMethodCount() {
-        return endpoints.stream()
-                .mapToInt(a -> a.children().size())
-                .sum();
+        return endpoints.stream().mapToInt(a -> a.children().size()).sum();
     }
 }
diff --git a/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/QuarkusHillaDevUICommonsProcessor.java b/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/QuarkusHillaDevUICommonsProcessor.java
index 54f144a..c062cfa 100644
--- a/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/QuarkusHillaDevUICommonsProcessor.java
+++ b/commons/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/QuarkusHillaDevUICommonsProcessor.java
@@ -15,6 +15,12 @@
  */
 package com.github.mcollovati.quarkus.hilla.deployment.devui;
 
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.Stream;
+
 import io.quarkus.deployment.IsDevelopment;
 import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
@@ -28,15 +34,10 @@ import org.jboss.jandex.AnnotationInstance;
 import org.jboss.jandex.AnnotationTarget;
 import org.jboss.jandex.DotName;
 
-import java.io.ByteArrayInputStream;
-import java.nio.charset.StandardCharsets;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.stream.Stream;
-
 public class QuarkusHillaDevUICommonsProcessor {
 
-    private static final GACT UI_JAR = new GACT("com.github.mcollovati", "quarkus-hilla-commons-deployment", null, "jar");
+    private static final GACT UI_JAR =
+            new GACT("com.github.mcollovati", "quarkus-hilla-commons-deployment", null, "jar");
     private static final String NAMESPACE = UI_JAR.getGroupId() + "." + UI_JAR.getArtifactId();
     private static final String DEV_UI = "dev-ui";
 
diff --git a/lit/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java b/lit/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
index eded8a0..2efb618 100644
--- a/lit/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
+++ b/lit/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
@@ -1,18 +1,32 @@
+/*
+ * Copyright 2024 Marco Collovati, Dario Götze
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.github.mcollovati.quarkus.hilla.devui;
 
-import com.github.mcollovati.quarkus.hilla.deployment.devui.EndpointBuildItem;
 import io.quarkus.deployment.IsDevelopment;
 import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
 import io.quarkus.devui.spi.page.CardPageBuildItem;
 import io.quarkus.devui.spi.page.Page;
 
+import com.github.mcollovati.quarkus.hilla.deployment.devui.EndpointBuildItem;
+
 public class QuarkusHillaDevUIProcessor {
 
     @BuildStep(onlyIf = IsDevelopment.class)
-    public void pages(
-            BuildProducer<CardPageBuildItem> cardPageProducer,
-            EndpointBuildItem endpointBuildItem) {
+    public void pages(BuildProducer<CardPageBuildItem> cardPageProducer, EndpointBuildItem endpointBuildItem) {
         CardPageBuildItem cardPageBuildItem = new CardPageBuildItem();
         final var page = Page.webComponentPageBuilder()
                 .title("Browser callables")
diff --git a/react/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java b/react/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
index 0db2ae7..2fd604a 100644
--- a/react/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
+++ b/react/deployment/src/main/java/com/github/mcollovati/quarkus/hilla/devui/QuarkusHillaDevUIProcessor.java
@@ -1,18 +1,32 @@
+/*
+ * Copyright 2024 Marco Collovati, Dario Götze
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.github.mcollovati.quarkus.hilla.devui;
 
-import com.github.mcollovati.quarkus.hilla.deployment.devui.EndpointBuildItem;
 import io.quarkus.deployment.IsDevelopment;
 import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
 import io.quarkus.devui.spi.page.CardPageBuildItem;
 import io.quarkus.devui.spi.page.Page;
 
+import com.github.mcollovati.quarkus.hilla.deployment.devui.EndpointBuildItem;
+
 public class QuarkusHillaDevUIProcessor {
 
     @BuildStep(onlyIf = IsDevelopment.class)
-    public void pages(
-            BuildProducer<CardPageBuildItem> cardPageProducer,
-            EndpointBuildItem endpointBuildItem) {
+    public void pages(BuildProducer<CardPageBuildItem> cardPageProducer, EndpointBuildItem endpointBuildItem) {
         CardPageBuildItem cardPageBuildItem = new CardPageBuildItem();
         final var page = Page.webComponentPageBuilder()
                 .title("Browser callables")

github-actions · 2024-11-03T13:35:46Z

Test Results

67 files ±0 67 suites ±0 14m 23s ⏱️ +30s
216 tests ±0 215 ✅ ±0 1 💤 ±0 0 ❌ ±0
316 runs ±0 315 ✅ ±0 1 💤 ±0 0 ❌ ±0

Results for commit 1bcf13c. ± Comparison against base commit 2ec5b77.

♻️ This comment has been updated with latest results.

mcollovati

Overall, looks excellent!
However, I noticed that methods defined in superclasses annotated with @EndpointExposed are not listed in the UI.
I guess this is because ClassInfo.methods() collects only method declared in the class and do not traverse the hierarchy

...loyment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointInfo.java

mcollovati · 2024-11-03T14:47:14Z

...loyment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointInfo.java

+                        .map(DotName::withoutPackagePrefix)
+                        .orElse(null),
+                accessAnnotation,
+                classInfo.methods().stream()


Would maybe use methodsInDeclarationOrder() to make the ordering consistent with the class definition.
Also, should collect methods from super classes annotated with @ExposedEndpoint

mcollovati · 2024-11-03T14:56:40Z

commons/deployment/src/main/resources/dev-ui/qwc-quarkus-hilla-endpoints.js

+            return html`
+                <vaadin-grid .dataProvider="${this._dataProvider}" .expandedItems="${this._expandedItems}"
+                             class="datatable" theme="row-stripes">
+                    <vaadin-grid-sort-column header="Class"


Sorting does not seem to work. Would it make sense to remove it?

That's true, didn't know how to correctly specify the sort parameter. If you can give me a hint, would be nice, otherwise we could remove it.

quarkus-hilla-bot bot added the format:required label Nov 3, 2024

Dudeplayz linked an issue Nov 3, 2024 that may be closed by this pull request

Add quarkus dev UI #33

Open

Dudeplayz force-pushed the issues/33-add-dev-ui branch from 44c7f5e to e25cc5a Compare November 3, 2024 13:22

quarkus-hilla-bot bot added format:checked and removed format:required labels Nov 3, 2024

mcollovati requested changes Nov 3, 2024

View reviewed changes

mcollovati reviewed Nov 3, 2024

View reviewed changes

Dudeplayz mentioned this pull request Nov 3, 2024

Add options to manipulate the Dev UI Card Page of another extension quarkusio/quarkus#44275

Closed

Dudeplayz added 5 commits November 26, 2024 22:01

Add Dev-UI

931ae86

Add guide link to quarkus-extension.yaml

505e0a9

Rename endpoints to browser callables

d1b28aa

Update extension names

b870a2e

Add browser callables to each dev-ui card page

1bcf13c

Dudeplayz force-pushed the issues/33-add-dev-ui branch from e25cc5a to 1bcf13c Compare November 26, 2024 22:06

quarkus-hilla-bot bot added format:required and removed format:checked labels Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add dev ui #1036

feat: add dev ui #1036

Dudeplayz commented Nov 3, 2024

quarkus-hilla-bot bot commented Nov 3, 2024 •

edited

Loading

github-actions bot commented Nov 3, 2024 •

edited

Loading

mcollovati left a comment

mcollovati Nov 3, 2024

mcollovati Nov 3, 2024

Dudeplayz Nov 3, 2024

feat: add dev ui #1036

Are you sure you want to change the base?

feat: add dev ui #1036

Conversation

Dudeplayz commented Nov 3, 2024

quarkus-hilla-bot bot commented Nov 3, 2024 • edited Loading

Format Checker Report

github-actions bot commented Nov 3, 2024 • edited Loading

Test Results

mcollovati left a comment

Choose a reason for hiding this comment

mcollovati Nov 3, 2024

Choose a reason for hiding this comment

mcollovati Nov 3, 2024

Choose a reason for hiding this comment

Dudeplayz Nov 3, 2024

Choose a reason for hiding this comment

quarkus-hilla-bot bot commented Nov 3, 2024 •

edited

Loading

github-actions bot commented Nov 3, 2024 •

edited

Loading