-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max-height value of "stretch" is missing from the listed Values #29887
Comments
This is valid, but for whoever does this it needs to also be added to these cases: width, height, inline-size, block-size, min-width, min-height, min-inline-size, min-block-size, max-width, max-height, max-inline-size, max-block-size - according to https://drafts.csswg.org/css-sizing-4/#sizing-values @graymatter00 Are you interested in adding this? |
Hi @hamishwillee. Good point on the need for the same requirement in the other size properties. 👍
I don't think my documentation writing skills are up to the challenge. I'll leave it to the good people who I'm sure can do a better job than me. |
No worries. @OnkarRuikar Just did some changes in this area and I'm hoping will jump on it. |
I didn't document The equivalent available value in chromium is I don't know if it is a good idea to document unimplemented experimental features because they tend to change a lot and not implemented. For example in case of |
@OnkarRuikar I knew you'd have a reason, but I saw it in the BCD. As you say, the rule is that we document stuff once there is an implementation. Either way, there is a bug here. I suspect that perhaps the BCD reflects the version in which |
Yes, as per the BCD policy Removal of irrelevant features the /cc @queengooborg |
Hi @OnkarRuikar, I started looking at your PR #35262, and I thought I could continue the discussion here instead of in the PR. I believe you had the correct idea in #29887 (comment) to not document the value
Looking at
Some other observations:
With the current discrepancies in browser compat data and "Formal syntax", my proposal is:
and
Let me know what you think. Also /cc @hamishwillee again to get his inputs. |
👍 Waiting for Hamish's opinion.
The
The values not appearing in Formal syntax is an yari issue mdn/yari#11607 .
The anchor-size.mp4 |
True, by definition (While we are trying to move away from vendor-specific prefixes (FAQ), browsers did not implement
I was trying it as a value in Thanks for opening the yari issue! |
This is a complicated set of questions and also it looks like some of them have already been agreed by you guys. But on quick scan my opinion:
In summary, "Always follow BCD but you can provide hints to non standard things in its docs". Is that helpful? If not, let me know the issues which there is disagreement on? |
Thanks, @hamishwillee. Thankfully, Syntax and Formal syntax do not mention the aliases; they appear only in BCD. @OnkarRuikar, when you have a moment, WDYT about making these updates to your PR:
If we're on the same page with the changes, I can proceed with reviewing the PR. Thanks! |
MDN URL
https://developer.mozilla.org/en-US/docs/Web/CSS/max-height
What specific section or headline is this issue about?
Values
What information was incorrect, unhelpful, or incomplete?
A description for the
stretch
value is missing. However, it is mentioned as a part of the description for thefit-content()
value, and it is in the Browser compatibility table.What did you expect to see?
An description for the
stretch
value.Do you have any supporting links, references, or citations?
No response
Do you have anything more you want to share?
No response
MDN metadata
Page report details
en-us/web/css/max-height
The text was updated successfully, but these errors were encountered: