Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / enhance / document the plot functions #341

Open
kanekosh opened this issue Sep 1, 2020 · 0 comments
Open

Refactor / enhance / document the plot functions #341

kanekosh opened this issue Sep 1, 2020 · 0 comments
Assignees

Comments

@kanekosh
Copy link
Contributor

kanekosh commented Sep 1, 2020

Type of issue

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Description

Plot scripts plot_wing.py, plot_wingbox.py have a lot to be improved.

  • Refactor: Two scripts have duplicated methods e.g. save_video. We should create a parent class to put the common parts.
  • Refactor: API for plot should be unified for all cases; specify the type of case (multipoint or not, wingbox or not) as an argument to the plot function.
  • We should be able to plot multipoint non-wingbox cases, as well as single-point wingbox ones.
  • plot_wing should be callable in the python script.
  • Update the document on visualization. In particular, add 1) how to run the plotter, 2) how you interpret the results (e.g. units of the lift).
  • Convergence plot via pyOptSparse and OptView.
@kanekosh kanekosh self-assigned this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant