From 4f9eb684ff309b4826c0dd99ddbcea6d9ab7a31e Mon Sep 17 00:00:00 2001 From: Marco Donadoni Date: Tue, 23 Jan 2024 15:19:05 +0100 Subject: [PATCH] refactor(workflow-run-manager): do not update status of jobs (#559) Let reana-job-controller update the status of jobs, as this is not a concern of reana-workflow-controller, which should manage workflows and not jobs. --- reana_workflow_controller/consumer.py | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/reana_workflow_controller/consumer.py b/reana_workflow_controller/consumer.py index 4f4e4d48..47021c43 100644 --- a/reana_workflow_controller/consumer.py +++ b/reana_workflow_controller/consumer.py @@ -105,7 +105,6 @@ def on_message(self, body, message): msg = body_dict["message"] if "progress" in msg: _update_run_progress(workflow_uuid, msg) - _update_job_progress(workflow_uuid, msg) # Caching: calculate input hash and store in JobCache if "caching_info" in msg: _update_job_cache(msg) @@ -226,22 +225,6 @@ def _update_run_progress(workflow_uuid, msg): Session.add(workflow) -def _update_job_progress(workflow_uuid, msg): - """Update job progress for jobs in received message.""" - for status_name, job_status in PROGRESS_STATUSES: - if status_name in msg["progress"]: - status_progress = msg["progress"][status_name] - for job_id in status_progress["job_ids"]: - try: - uuid.UUID(job_id) - except Exception: - continue - job = Session.query(Job).filter_by(id_=job_id).one_or_none() - if job: - job.workflow_uuid = workflow_uuid - job.status = job_status - - def _update_job_cache(msg): """Update caching information for finished job.""" cached_job = (