Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVN enhancements #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

EvilBMP
Copy link

@EvilBMP EvilBMP commented Jun 15, 2018

I am lazy, so I just c&p my commit messages here ;-) Thanks for your work...

[TASK] adds svn branch/ tag name to bash prompt as well
[BUGFIX] updates/ normalizes the "not a svn sandbox" test/ condition
[CLEANUP] remove read-only flag from BPVCS_VERSION variable as it outputs warnings

[TASK] updates readme and screenshot

EvilBMP added 3 commits June 15, 2018 10:32
[BUGFIX] updates/ normalizes the "not a svn sandbox" test/ condition
[CLEANUP] remove read-only flag from BPVCS_VERSION variable as it outputs warnings
@meadowface
Copy link
Owner

Thanks for the mods! After a quick glance, it looks like a strict improvement to the svn support. I'll try to make time to really dig into it and merge it soon. Thanks again.

@meadowface
Copy link
Owner

I am curious about making the version non-readonly. What warnings were you seeing? I like the fact that it's read-only, but have had a few offline conversations with other people who find it annoying, so I'm considering changing it.

@EvilBMP
Copy link
Author

EvilBMP commented Jun 27, 2018

Sorry for the late reply. After sourcing the .bashrc I see the following output in the bash console.

-bash: declare: BPVCS_VERSION: Schreibgeschützte Variable. (sorry german bash ;-) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants