Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-9220: Respect forcegroupmode #53

Merged
merged 3 commits into from
Dec 15, 2024
Merged

MBS-9220: Respect forcegroupmode #53

merged 3 commits into from
Dec 15, 2024

Conversation

sh-csg
Copy link
Contributor

@sh-csg sh-csg commented Jun 24, 2024

No description provided.

@sh-csg sh-csg added this to the 0.3 milestone Jun 24, 2024
@sh-csg sh-csg self-assigned this Jun 24, 2024
@sh-csg sh-csg linked an issue Jun 24, 2024 that may be closed by this pull request
Group boards don't work inside courses that enable "force group mode" #52
Closed
@sh-csg sh-csg mentioned this pull request Jun 24, 2024
Closed
@sh-csg
Copy link
Contributor Author

sh-csg commented Jun 24, 2024

Failing GHA is not related to this PR

PhMemmel
PhMemmel reviewed Sep 18, 2024
View reviewed changes
view.php Outdated Show resolved Hide resolved
PhMemmel
PhMemmel requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good if the navigation node in the 3 dots menu besides the board title would not show "show shared board". If I understand the intended behavior correctly once you are in forced group mode you should not be able to see the shared board, right?

@sh-csg
Copy link
Contributor Author

sh-csg commented Dec 14, 2024

Shared board is (as in group mode) just available to the trainer. This is meant to be a place where you can prepare some cards / columns for a template board.

@PhMemmel
Copy link
Member

Thank you for clarifying. It should not be available in the board selection dropdown to the students then I'd suggest.

@PhMemmel PhMemmel merged commit 4b1b808 into master Dec 15, 2024
0 of 24 checks passed
@PhMemmel
Copy link
Member

For documentation purposes: The addEventListener change fixed an console error which you could see when entering a kanban board in group mode as student (missing navigation node caused this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhMemmel PhMemmel PhMemmel requested changes

Assignees

@sh-csg sh-csg

Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

Group boards don't work inside courses that enable "force group mode"
2 participants
@sh-csg @PhMemmel