Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-8337: Show kanbans in block activity_modules #63

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

fdagner
Copy link
Contributor

@fdagner fdagner commented Sep 23, 2024

No description provided.

index.php Outdated Show resolved Hide resolved
index.php Show resolved Hide resolved
index.php Show resolved Hide resolved
index.php Show resolved Hide resolved
index.php Show resolved Hide resolved
index.php Outdated Show resolved Hide resolved
index.php Outdated Show resolved Hide resolved
Copy link
Member

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor issue, besides that looks good

index.php Outdated Show resolved Hide resolved
lang/en/kanban.php Outdated Show resolved Hide resolved
@fdagner fdagner force-pushed the MBS-8337_view_in_activity_modules branch from 6e7d36a to b1fff93 Compare October 30, 2024 15:22
lang/en/kanban.php Outdated Show resolved Hide resolved
Copy link
Member

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job! Tested as teacher and student, with hidden activities and completion restriction, works as expected.

@PhMemmel PhMemmel changed the title Show kanbans in block activity_modules MBS-8337: Show kanbans in block activity_modules Nov 5, 2024
@PhMemmel PhMemmel merged commit 5931b77 into master Nov 5, 2024
0 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants