Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-9449_Filereport_for_uploaded_files #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bblumenfelder
Copy link

  • Implemented filereport-property in manager.php that stores stats about imported or skipped files.
  • Template filereport.mustache shows bootstrap collapsible component with filelist

Possible improvements:

  • manager.php in Line 278ss.
                    // Parse metadata.json and get 'filename'-value.
                    if ($file->get_filename() == 'metadata.json') {
                        $targetfilename = json_decode($file->get_content(), true)['filename'];
                    }

metadata.json is parsed twice with conflicts with DRY-principle

@bblumenfelder bblumenfelder requested a review from sh-csg January 5, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant