Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit matching #49

Open
nc opened this issue Oct 18, 2014 · 5 comments
Open

Explicit matching #49

nc opened this issue Oct 18, 2014 · 5 comments

Comments

@nc
Copy link
Contributor

nc commented Oct 18, 2014

Perhaps a better way to handle matching edge cases would be to specify the relative path of the CSS or SCSS file that the link tag should be matched with.

So for cache busting urls, or differing paths that have no easy resolution you would write:
<link href="/media/main.css" takana-href="/styles/main.scss" />

Where /styles/main.scss is resolved starting with PATH in takana PATH

@nc
Copy link
Contributor Author

nc commented Oct 18, 2014

This would also fix false positives.

@barnaby
Copy link
Contributor

barnaby commented Oct 18, 2014

Yea, I like this. Let's do it!

@barnaby
Copy link
Contributor

barnaby commented Oct 18, 2014

Would also be pretty easy to implement (the browser already knows full file paths)

@nc
Copy link
Contributor Author

nc commented Oct 20, 2014

Done, will add tests and documentation this week.

@lukeb
Copy link

lukeb commented Dec 19, 2014

I like this option too. It would definitely help with incorrect false positive matches. I've had issues with this.

Another thing that would be helpful is a way to disable takana for certain tags. Perhaps a data-takana="false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants