Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/explore, /write, /sketch: add to bookmarks workflow issues #128

Open
1 of 2 tasks
andirueckel opened this issue Jan 19, 2024 · 0 comments
Open
1 of 2 tasks

/explore, /write, /sketch: add to bookmarks workflow issues #128

andirueckel opened this issue Jan 19, 2024 · 0 comments

Comments

@andirueckel
Copy link
Member

andirueckel commented Jan 19, 2024

-- Branch: bookmark-feature + develop --

Steps to reproduce the problem

  • Navigate to /write and open open one of your pad items.
  • Click the add to bookmarks button in the top right corner.

Issues

  • The loading spinner needs more width, and leads to visual flickering/movement.
  • The check mark emoji, after the loading spinner, needs to be changed to use the check mark icon (svg). 4c9d0f2

Improvements

In addition to these issues, it would be great if the add to bookmarks button would be stateful, i.e. if the item is bookmarked, either disable the button, or replace the button with a remove from bookmarks button with respective icon.

andirueckel added a commit that referenced this issue Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant