Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invited user unable to access /spacedeck sketches #99

Open
aofn opened this issue Nov 21, 2023 · 0 comments
Open

Invited user unable to access /spacedeck sketches #99

aofn opened this issue Nov 21, 2023 · 0 comments
Assignees
Labels
bug Something isn't working spacdeck

Comments

@aofn
Copy link
Member

aofn commented Nov 21, 2023

Describe the bug
When a sketch is sent as an invitation to another user #42, the invited user is unable to open the sketch if it is set to private (which they are by default).
On top of that, users can't to change the visibility of sketches through /spaces.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new sketch
  2. Send an invitation to another user to access the sketch (if Invite users to service rooms  #42 is not yet merged you can checkout the branch or use element).
  3. Log in as the invited user and attempt to open the sketch.
  4. The iframe shows the spacedeck landing page

Expected behavior
Invited users should be able to access and open sketches they've been invited to, regardless of the sketch's visibility setting.

Screenshots
image

Suggested solution
The most straightforward solution to this issue would be to set the visibility of newly created sketches to public by default.

Alternatively, we have to simultaniously invite people to a spacdeck sketch with the spacedeck api (have not checked if this is possible) and keep the two in sync. Which imo is not worth the hassle of a private sketch atm.

@aofn aofn added bug Something isn't working spacdeck labels Nov 21, 2023
@robertschnuell robertschnuell self-assigned this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spacdeck
Projects
None yet
Development

No branches or pull requests

2 participants