Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL license for a package that is never imported #19

Open
jdposada opened this issue Nov 29, 2023 · 1 comment
Open

GPL license for a package that is never imported #19

jdposada opened this issue Nov 29, 2023 · 1 comment

Comments

@jdposada
Copy link

The unidecode package is mentioned on the requirements.txt. However, I did not find an import for it. Not sure what package requires it. My suggestion is to replace it with a package that has a friendlier license.

@burgersmoke
Copy link
Collaborator

We've been discussing this in our Slack channel, but here's a bit of context here that we can track since I followed up on this:

medspacy QuickUMLS still does use unidecode. An example of it is here:

https://github.com/medspacy/QuickUMLS/blob/master/quickumls/core.py

Specifically, it use used to optionally normalize unicode here:

if self.normalize_unicode_flag:

Here's what the code looks like:

            if self.normalize_unicode_flag:
                ngram_normalized = unidecode(ngram_normalized)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants