Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cicd): semver and push container image to ghcr.io #12

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat(cicd): semver and push container image to ghcr.io #12

merged 2 commits into from
Apr 17, 2024

Conversation

nicolasdecorbez
Copy link
Contributor

@nicolasdecorbez nicolasdecorbez commented Apr 16, 2024 •
edited
Loading

Closes #3
Closes #4

WARNING: the GITHUB_TOKEN secret has not been set yet on the repo config.

@nicolasdecorbez nicolasdecorbez requested a review from tbobm as a code owner April 16, 2024 16:21
@nicolasdecorbez nicolasdecorbez self-assigned this Apr 16, 2024
@nicolasdecorbez nicolasdecorbez added the enhancement New feature or request label Apr 16, 2024
@tbobm
Copy link
Member

tbobm commented Apr 17, 2024

@nicolasdecorbez there is no need to set the GITHUB_TOKEN secret as it is automatically provisioned

tbobm
tbobm approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@tbobm tbobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nicolasdecorbez nicolasdecorbez merged commit 2b575b2 into main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbobm tbobm tbobm approved these changes

Assignees

@nicolasdecorbez nicolasdecorbez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include semantic release upon merging Change registry target to ghcr.io
2 participants
@nicolasdecorbez @tbobm