Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy] Telegram Dark Theme #4

Open
ldrrp opened this issue Oct 18, 2017 · 8 comments
Open

[Deploy] Telegram Dark Theme #4

ldrrp opened this issue Oct 18, 2017 · 8 comments
Labels

Comments

@ldrrp
Copy link

ldrrp commented Oct 18, 2017

Service

Telegram

Link to your repository

https://github.com/SiloCityLabs/recipe-franz-telegram-dark

@adlk
Copy link
Contributor

adlk commented Oct 18, 2017

Thanks for your plugin!
I'm not going to deploy this right now as it would be a service duplicate. Instead I'm waiting for the settings API to be finished to merge your plugin with the existing one. . This allows us to add a setting to enable/disable the dark mode.

@ldrrp
Copy link
Author

ldrrp commented Oct 18, 2017

Yea i though about that afterward, i will be creating a pull request into your main recipe and adding a toggle into the menu by injecting js/css, how would that sound?

@adlk
Copy link
Contributor

adlk commented Oct 18, 2017

As long as it's not too intrusive it would be a great quick fix.

@adlk
Copy link
Contributor

adlk commented Oct 18, 2017

While you are at it, can you please take a look at this issue as well meetfranz/recipe-telegram#1

I believe it should be fixed by adding a simple media query.

@ldrrp
Copy link
Author

ldrrp commented Oct 18, 2017

Sure thing

@ldrrp
Copy link
Author

ldrrp commented Oct 18, 2017

It seems I have similar issues with most services, I was gonna run through them all afterwards and fix their sizing issues. I like my chat clients to be small windows out of the way

@ldrrp
Copy link
Author

ldrrp commented Oct 19, 2017

I have created a toggle and pull request. meetfranz/recipe-telegram#2

@adlk
Copy link
Contributor

adlk commented Nov 8, 2017

@ldrrp I'm getting a TypeError that is caused by adding the toggle.

@adlk adlk added the bug label Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants